Only return 'normal' as the range when no value is given.#185
Merged
bramus merged 1 commit intoflackr:masterfrom Dec 24, 2023
Merged
Only return 'normal' as the range when no value is given.#185bramus merged 1 commit intoflackr:masterfrom
bramus merged 1 commit intoflackr:masterfrom
Conversation
Fixes the error “Can’t assign to property "rangeName": not an object”
Closed
Contributor
|
I'm so sorry. I think it might be better to just roll back #178. I was too optimistic when rebasing on top of the recent changes, and leaned too heavily on the WPT test result being ok. If not rolled back, #187 should probably be merged as well, as there is an issue matching the range names |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #178
parseAnimationRangewas changed to use string values of"normal"instead of objects representing the normal range. This essentially broke the parsing ofanimation-range, as later on that function tries to update values in that (now inexistent) object.On the console, these errors could be seen, as reported in #183:
This PR fixes this: return the default
"normal"when no value is given, but continue with the objects when there is a value to parse.Note that this is only for parsing ranges of
ViewTimelimeinstances. ForScrollTimeline, more work needs to be done in #153.PS: I didn’t get to updating the test results as I’ve got issues launching them with firefox for some reason. Safari works fine, but gives totally different base results.