Merged
Conversation
johannesodland
force-pushed
the
fix-unattached-subject-inset
branch
2 times, most recently
from
79547f3 to
dc12f9b
Compare
johannesodland
force-pushed
the
fix-unattached-subject-inset
branch
from
dc12f9b to
ee6f454
Compare
flackr
requested changes
Feb 5, 2024
johannesodland
force-pushed
the
fix-unattached-subject-inset
branch
from
ee6f454 to
5a934bb
Compare
johannesodland
force-pushed
the
fix-unattached-subject-inset
branch
from
5a934bb to
b40f1c9
Compare
flackr
approved these changes
Feb 5, 2024
Owner
Collaborator
|
Yeah, those SVG tests are flaky. Often simply retriggering the test fixes it. I see @johannesodland is also working on a PR that try and get these tests to pass: #227 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes /scroll-animations/view-timelines/unattached-subject-inset.html pass.