Realign start time if finite timeline and auto-rewind is true#237
Open
johannesodland wants to merge 1 commit intoflackr:masterfrom
Open
Realign start time if finite timeline and auto-rewind is true#237johannesodland wants to merge 1 commit intoflackr:masterfrom
johannesodland wants to merge 1 commit intoflackr:masterfrom
Conversation
johannesodland
force-pushed
the
fix-auto-align-after-pause
branch
2 times, most recently
from
7351107 to
ab6f21a
Compare
johannesodland
changed the title
Contributor
Author
|
What is the best approach here, when the spec, wpt tests and Chrome implementation differ? Should we raise an issue in the csswg-issues repo? Or is it just that the tests and implementation is behind the spec? |
johannesodland
force-pushed
the
fix-auto-align-after-pause
branch
from
ab6f21a to
b908589
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another two tests where the spec and the wpt does not align.
The wpt tests suggests that the start time should be auto aligned when playing an animation, as long as the finite timeline and auto-rewind flags are true. Chrome currently passes these tests.
I think it's best to follow the test and Chromes implementation here, and adjust later if necessary?