Fix: De-activate animation when scroll container has no overflow#302
Open
dnlzro wants to merge 1 commit intoflackr:masterfrom
Open
Fix: De-activate animation when scroll container has no overflow#302dnlzro wants to merge 1 commit intoflackr:masterfrom
dnlzro wants to merge 1 commit intoflackr:masterfrom
Conversation
|
Instantly no annoying "Animation.currentTime" errors anymore, lovely. I use it for a scrollbar indicator approach and I learned that it works this solution works with indicators as pseudo elements but not as real DOM nodes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This polyfill applies scroll-driven animations even when the scroll container has no overflow (i.e., when
clientHeight === scrollHeight). According to the specification (source):When there is no overflow, then scrollable overflow size − scroll container size = 0. Currently, the timeline is set to 100% or
NaNin these cases. Instead, it should be set to inactive.Changes
ScrollTimeline.currentTime: ReturnunresolvedwhenmaxScrollPos <= 0.ViewTimeline.currentTime: Returnunresolvedwhenoffsets.end === offsets.start.Note: When the
currentTimemethod returnsunresolved(i.e.,null), thetickAnimationfunction will cancel the animation. This ensures no effects are applied when the timeline is inactive.Note: I think these changes also indirectly address the first issue raised in #298.