Conversation
jtraglia
marked this pull request as ready for review
February 21, 2025 17:38
metachris
reviewed
Feb 24, 2025
| err = signedValidatorRegistrations.UnmarshalSSZ(regBytes) | ||
| default: | ||
| log.Debug("Parsing registrations as JSON") | ||
| err = json.Unmarshal(regBytes, signedValidatorRegistrations) |
Collaborator
There was a problem hiding this comment.
This request comes in huge bursts (at epoch boundary), and decoding the JSON is a huge bottleneck. That's why we've moved to the fast json decode above, that this PR deleted. We definitely need the previous fast json decoding, otherwise it's a huge bottleneck in production.
metachris
reviewed
Apr 10, 2025
Comment on lines
+57
to
+62
| ApplicationJSON = "application/json" | ||
| ApplicationOctetStream = "application/octet-stream" | ||
|
|
||
| HeaderAccept = "Accept" | ||
| HeaderContentType = "Content-Type" | ||
| HeaderEthConsensusVersion = "Eth-Consensus-Version" |
Collaborator
There was a problem hiding this comment.
best move to constants.go
metachris
approved these changes
Apr 10, 2025
metachris
left a comment
metachris
left a comment
Collaborator
There was a problem hiding this comment.
looks good overall. has it been tested successfully on testnets/devnet tests yet?
Collaborator
Author
|
It has not been thoroughly tested. |
barnabasbusa
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR adds SSZ support to the Proposer API endpoints, as described here:
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md