Don't increment Sturm sign change count twice at each 0#302
Merged
Conversation
d-torrance
changed the title
Contributor
Author
|
Fixed -- in the original version of this PR, we weren't counting any roots at 0. |
Previously, if 0 appeared in the values of the elements of Sturm
sequence at an endpoint, we counted two sign changes instead of one,
e.g., {1, 0, -1, 0, 1, -1, 0} -> 5 changes instead of 3.
In addition to the 10 random polynomials, we test one specific one where the previous algorithm miscounted the number of sign changes.
Collaborator
|
Thanks for looking at it! Code looks code. Let see what CI says. |
Member
|
The CI needed some updating. The fixes are (hopefully) in #303. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if 0 appeared in the values of the elements of the Sturm sequence at an endpoint, we counted two sign changes instead of one, e.g., {1, 0, -1, 0, 1, -1, 0} -> 5 changes instead of 3.
Checklist
doc/news/.Fixes: #301