Open
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DB能自动处理Connections的连接错误，因此如果不是系统性的错误，例如: 用户名错误等等，创建DB原则上不应该返回error。因此checkConn可以延后创建，或者创建失败了就直接跳过； InitConnNum也尽可能满足，如果不能满足也跳过
UpMaster & DownMaster 只负责处理Admin相关的逻辑，由外部行为驱动；
checkMaster 属于内部行为，如果Node处于Down状态，那么checkMaster不工作；如果Node处于UpMaster状态，则checkMaster正常工作；checkMaster本身不改变UpMaster/DownMaster的逻辑。
DB的状态一方面是看是否为nil, 另一方面看是否处于UP状态