Skip to content

Relocate gizmo badges when gizmos span two rows #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawsie merged 2 commits into from
Jul 21, 2026
Merged

Relocate gizmo badges when gizmos span two rows #715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58686af
Relocate gizmo badges
lawsie Jul 21, 2026
997476e
Reformat comment
lawsie Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions accessibility/keyboardui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,14 +358,21 @@ const GizmoMenuManager = {
renderBadges() {
const container = document.getElementById('gizmo-menu-content');
container.innerHTML = '';
this.buttons.forEach((entry) => {
const el = document.getElementById(entry.id);
if (!el || el.offsetParent === null) return;
const rect = el.getBoundingClientRect();
const visible = this.buttons
.map((entry) => {
const el = document.getElementById(entry.id);
if (!el || el.offsetParent === null) return null;
return { entry, rect: el.getBoundingClientRect() };
})
.filter(Boolean);
// If badges span two rows, put top row badges on top
const bottomRowTop = Math.max(...visible.map(({ rect }) => rect.top));
visible.forEach(({ entry, rect }) => {
const badge = document.createElement('div');
badge.className = 'gizmo-key-badge';
badge.innerText = entry.label;
badge.style.top = `${rect.top + rect.height + 8}px`;
const isBottomRow = rect.top >= bottomRowTop - rect.height / 2;
badge.style.top = isBottomRow ? `${rect.top + rect.height + 8}px` : `${rect.top - 8}px`;
badge.style.left = `${rect.left + rect.width / 2}px`;
container.appendChild(badge);
});
Expand Down
Loading