Fix selection and block highlight on workspace search - #725
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughMobile workspace search gains ArrowUp/ArrowDown navigation, synchronizes its current result with Blockly selection, and updates desktop and low-vision match highlighting to use Blockly-selected paths. ChangesWorkspace search interaction
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant MobileSearchInput
participant workspaceSearch
participant BlocklyWorkspace
MobileSearchInput->>workspaceSearch: next() or previous()
workspaceSearch->>BlocklyWorkspace: select current block
BlocklyWorkspace->>workspaceSearch: selected block change
workspaceSearch->>workspaceSearch: update current result
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where clicking on a search result block would result in it turning fully yellow.
Sets the first result as the current selection to avoid weird cursor behaviour/confusing highlights.
AI usage
Claude Opus 5 used throughout. Plan created by me. Realised the previous implementation was not a good idea and changed it.
Summary by CodeRabbit
New Features
Bug Fixes