This repository was archived by the owner on Apr 6, 2026. It is now read-only.
Update Terraform cloudposse/cloudfront-s3-cdn/aws to v1 - autoclosed#8
Closed
renovate[bot] wants to merge 1 commit into
Closed
Update Terraform cloudposse/cloudfront-s3-cdn/aws to v1 - autoclosed#8renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
f792fe2 to
420ceb5
Compare
420ceb5 to
df16446
Compare
df16446 to
8c1f23a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.97.0→1.1.1Release Notes
cloudposse/terraform-aws-cloudfront-s3-cdn (cloudposse/cloudfront-s3-cdn/aws)
v1.1.1Compare Source
docs: clarify distribution comment is the description @oycyc (#353)
The comment corresponds to the description on the AWS console UI! Updating the text here so it's more easily aware.
Generate readme for submodules @goruha (#362)
what
why
references
v1.1.0Compare Source
fix: error: No more than 1 "s3_origin_config" blocks are allowed @Eyjafjallajokull (#359)
what
No more than 1 s3_origin_config blocks are allowederror when using multiple S3 origins with origin access identity enabledfor_eachfrom iterating overvar.s3_originsto using[1]to create a singles3_origin_configblockwhy
references
fixes #325
to reproduce error
origin_access_controlwithorigin_access_identityhttps://github.com/Eyjafjallajokull/terraform-aws-cloudfront-s3-cdn/blob/96703043867c986ff3fc1550448118111a9f5659/examples/complete/main.tf#L102
terraform planfails with the above error.v1.0.1Compare Source
🚀 Enhancements
fix: Resolve unsupported attribute error in S3 website block @jwadolowski (#358)
what
Restore
lookup()calls inmain.tfto address thewebsite_enabled = trueuse case that was broken when #340 replaced them with explicit variable calls to avoid silent default value assignments. Additionally includes corresponding module instances in the test suite.why
website_enabled = trueimplies a reference to 2 mutually exclusive configurations defined as thelocal.website_configvariable. In the default case,index_document,error_document, androuting_ruleselements exist, butredirect_all_requests_todoes not, which leads to the following error:Similarly,
website_enabled = truecombined withredirect_all_requests_to = "https://example.com"would result in missing references to theindex_document,error_document, androuting_rulesfields.All in all, in this particular case, the
lookup()usage is definitely justified and does not mean a silent/hidden injection of a variable default.references
v1.0.0Compare Source
feat: Backport cloudposse/cloudfront-cdn/aws improvements @jwadolowski (#340)
what
Backport of the following cloudposse/terraform-aws-cloudfront-cdn improvements:
Detailed breakdown:
aws_s3_bucket_cors_configurationis deployed only when at least one CORS origin is defined (examples/complete/minimal.tffails if this isn't handled)lookup()(or any other default variable value fallback method) - all defaults should be defined in thevariables.tffileoptional()and provide sane defaults (in most cases that'd be empty string/list/nullor predefined AWS default when applicable, e.g. timeout values)origin_keepalive_timeoutandorigin_read_timeoutorigin_access_control_idassignment (origin.value.s3_origin_config.origin_access_control_iddoesn't exist, butorigin.value.origin_access_control_iddoes)cookieblock should setwhitelisted_namesparam only whenforward=whitelist(in all other cases,allandnone, thewhitelisted_namesis automatically set tonull)why
Both CloudPosse CDN modules should stay in sync (feature-wise) and leverage the same set of improvements.
references
includes #347 to re-generate docs after changes.#347should get merged firstv0.98.2Compare Source
🤖 Automatic Updates
chore(deps): update terraform cloudposse/s3-log-storage/aws to v1.4.5 (release/v0) @[renovate[bot]](https://redirect.github.com/apps/renovate) (#351)
This PR contains the following updates:1.4.2->1.4.5Release Notes
cloudposse/terraform-aws-s3-log-storage (cloudposse/s3-log-storage/aws)
v1.4.5Compare Source
🚀 Enhancements
fix: remove join calls on bucket arn + id usage @​carterdanko-dw (#​125)
what
references
issue
#122🐛 Bug Fixes
fix: remove join calls on bucket arn + id usage @​carterdanko-dw (#​125)
what
references
issue
#122v1.4.4Compare Source
🚀 Enhancements
Issue-122/Values expect list of strings vs string @​carterdanko-dw (#​123)
what
Updating the sqs iam permissions, as the values expects to be a list of strings vs just the single string arn that is the output of the module.
why
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam\\_policy\\_document#condition-1 expects to be a list of strings, vs just the single string arn of the s3 bucket.
references
Github issue #122
🐛 Bug Fixes
Issue-122/Values expect list of strings vs string @​carterdanko-dw (#​123)
what
Updating the sqs iam permissions, as the values expects to be a list of strings vs just the single string arn that is the output of the module.
why
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam\\_policy\\_document#condition-1 expects to be a list of strings, vs just the single string arn of the s3 bucket.
references
Github issue #122
🤖 Automatic Updates
Migrate new test account @​osterman (#​119)
what
.github/settings.yml.github/chatops.ymlfileswhy
.github/settings.ymlfrom org level to getterratestenvironmenttestaccountReferences
Update .github/settings.yml @​osterman (#​118)
what
.github/settings.yml.github/auto-release.ymlfileswhy
.github/settings.ymlfrom org levelreferences
Update .github/settings.yml @​osterman (#​112)
what
.github/settings.yml.github/auto-release.ymlfileswhy
.github/settings.ymlfrom org levelreferences
Update .github/settings.yml @​osterman (#​111)
what
.github/settings.yml.github/auto-release.ymlfileswhy
.github/settings.ymlfrom org levelreferences
Update release workflow to allow pull-requests: write @​osterman (#​110)
what
.github/workflows/release.yaml) to have permission to comment on PRwhy
Update GitHub Workflows to use shared workflows from '.github' repo @​osterman (#​109)
what
.github/workflows) to use shared workflows from.githubrepowhy
Update GitHub Workflows to Fix ReviewDog TFLint Action @​osterman (#​108)
what
.github/workflows) to addissue: writepermission needed by ReviewDogtflintactionwhy
Update GitHub workflows @​osterman (#​107)
what
.github/workflows/settings.yaml)why
Use GitHub Action Workflows from `cloudposse/.github` Repo @​osterman (#​106)
what
why
cldouposse/.githubrepositoryAdd GitHub Settings @​osterman (#​104)
what
.github/settings.yaml)why
Update README.md and docs @​cloudpossebot (#​99)
what
This is an auto-generated PR that updates the README.md and docs
why
To have most recent changes of README.md and doc from origin templates
Update Scaffolding @​osterman (#​100)
what
make readmeto rebuildREADME.mdfromREADME.yamlwhy
.githubrepov1.4.3Compare Source
🤖 Automatic Updates
Update Terraform cloudposse/s3-bucket/aws to v3.1.3 (main) @​renovate (#​95)
This PR contains the following updates:
3.1.2->3.1.3Release Notes
cloudposse/terraform-aws-s3-bucket (cloudposse/s3-bucket/aws)
v3.1.3Compare Source
Unfortunately, this change makes
countunknown at plan time in certain situations. In general, you cannot use the output ofcompact()incount.The solution is to stop using the deprecated
policyinput and revert to 3.1.2 or upgrade to 4.0.🚀 Enhancements
Fix `source_policy_documents` combined with `var.policy` being ignored @​&#​8203;johncblandii (#&#​8203;201)
what
var.source_policy_documentstolocal.source_policy_documentssovar.policyusage was still supportedwhy
var,source_policy_documentssovar.policybeing combined withvar.source_policy_documentsintolocal.source_policy_documentsdoes not providetruefor the ternary to executereferences
Update README.md and docs @​cloudpossebot (#​94)
what
This is an auto-generated PR that updates the README.md and docs
why
To have most recent changes of README.md and doc from origin templates
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
v0.98.1Compare Source
fix(lambda@edge): Add support for doc auto-generation with atmos @jwadolowski (#347)
what
README.mdgeneration support withatmosCLI.why
#342 replaced
Makefilewithatmos.yamlfor the main module, but Lambda@Edge submodule got overlooked.references
🤖 Automatic Updates
Fix go version in tests @osterman (#343)
what
1.24why
References
Replace Makefile with atmos.yaml @osterman (#342)
what
Makefileatmos.yamlwhy
build-harnesswithatmosfor readme genrationReferences
v0.98.0Compare Source
fix: terratest w/ go updates @oycyc (#337)
Not familiar with how Go works, but following the suggestions to update packages looks to fix the tests in this repository!The commands I executed per @Nuru 's suggestion on Slack:
Slack thread here on CloudPosse: https://sweetops.slack.com/archives/G014YEKDH4K/p1748635698940509?thread_ts=1746672149.263629&cid=G014YEKDH4K
🚀 Enhancements
replace TLSv1.2_2019 with TLSv1.2_2021 as default policy @jamerply (#294)
what
This PR updates the
mimimum_protocol_versionvariable so that it defaults toTLSv1.2_2021(the current recommended security policy recommended by AWS) instead ofTLSv1.2_2019.why
The most current security policy is no longer
TLSv1.2_2019but isTLSv1.2_2021.references
See the "Security Policy" heading under the "Distribution Setting" section of the AWS CloudFront Documentation for further information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.