Skip to content

fix(imap): oauth2 url fix for outlook - #1701

Merged
andrinoff merged 1 commit into
floatpane:masterfrom
1unarzDev:fix
Jul 27, 2026
Merged

fix(imap): oauth2 url fix for outlook#1701
andrinoff merged 1 commit into
floatpane:masterfrom
1unarzDev:fix

Conversation

@1unarzDev

Copy link
Copy Markdown
Contributor

What?

  • Added try-catch block to make it easier to debug OAuth2 errors encountered while authenticating IMAP.
  • Revised Outlook URL generation code for updated Entra ID redirect

Why?

I wasn't able to authenticate my Outlook emails previously. I'm not fully sure if the documentation clearly states that you need your Entra ID redirect to be configured as "Web" rather than "Mobile & Desktop App," but that is also a needed fix.

@1unarzDev
1unarzDev requested a review from a team as a code owner July 24, 2026 18:44
@floatpanebot floatpanebot added area/oauth OAuth / XOAUTH2 / auth flows bug Something isn't working area/config Configuration / settings documentation Documentation changes os/windows Windows-specific labels Jul 24, 2026

@floatpanebot floatpanebot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @1unarzDev! Please fix the following issues with your PR:

  • Title: Is too long (67 characters). The PR title must be strictly under 40 characters.

@floatpanebot floatpanebot added the size/S Diff: 11–50 lines label Jul 24, 2026
@1unarzDev 1unarzDev changed the title fix(imap): oauth2 url generation fix for microsoft outlook entra id fix(imap): oauth2 url fix for outlook Jul 24, 2026
@floatpanebot
floatpanebot dismissed their stale review July 24, 2026 18:45

Formatting issues have been resolved. Thank you!

@andrinoff andrinoff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@floatpanebot floatpanebot added the backport/v1 Merge to master and backport to release/v1 label Jul 27, 2026
@andrinoff
andrinoff added this pull request to the merge queue Jul 27, 2026
Merged via the queue into floatpane:master with commit 87bc332 Jul 27, 2026
39 of 41 checks passed
floatpanebot pushed a commit that referenced this pull request Jul 27, 2026
## What?

- Added try-catch block to make it easier to debug OAuth2 errors
encountered while authenticating IMAP.
- Revised Outlook URL generation code for updated Entra ID redirect

## Why?

I wasn't able to authenticate my Outlook emails previously. I'm not
fully sure if the documentation clearly states that you need your Entra
ID redirect to be configured as "Web" rather than "Mobile & Desktop
App," but that is also a needed fix.

(cherry picked from commit 87bc332)
@floatpanebot floatpanebot added the backported Cherry-picked onto release/v1 label Jul 27, 2026
@floatpane floatpane deleted a comment from andrinoff Jul 27, 2026
@floatpane floatpane deleted a comment from andrinoff Jul 27, 2026
@1unarzDev
1unarzDev deleted the fix branch July 27, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Configuration / settings area/oauth OAuth / XOAUTH2 / auth flows backport/v1 Merge to master and backport to release/v1 backported Cherry-picked onto release/v1 bug Something isn't working documentation Documentation changes os/windows Windows-specific size/S Diff: 11–50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants