Add support for TLS-ALPN01 ACME protocol#8
Merged
flobernd merged 8 commits intoflobernd:masterfrom Mar 28, 2025
Merged
Conversation
Owner
|
Hi @kaashyapan, thanks a lot for the PR! I will review over the weekend 🙂 |
flobernd
reviewed
Jan 10, 2025
Owner
flobernd
left a comment
flobernd
left a comment
There was a problem hiding this comment.
LGTM, thanks again. Just a few minor documentation/README related suggestions.
Co-authored-by: Florian Bernd <mail@flobernd.de>
Co-authored-by: Florian Bernd <mail@flobernd.de>
Co-authored-by: Florian Bernd <mail@flobernd.de>
Co-authored-by: Florian Bernd <mail@flobernd.de>
Co-authored-by: Florian Bernd <mail@flobernd.de>
Co-authored-by: Florian Bernd <mail@flobernd.de>
Contributor
Author
|
Hi there, Any chance you can merge this ? |
Owner
|
Hey @kaashyapan sorry for the delay, I didn't had time to look at it again. Will merge later today! |
flobernd
approved these changes
Mar 28, 2025
Owner
|
Thanks again! Merged. Will trigger a release now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by
haproxy/haproxy#1864 (comment)
&
https://github.com/acmesh-official/acme.sh/wiki/TLS-ALPN-without-downtime