fix: persist writable contexts in workspace scope - #2320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Cloud binds each run to its workspace before entering the engine. The engine then nested
use_context_scope(context_scope_for_user(owner_id))calls in run service and both runtime paths. Those calls replaced the active workspace with the account ID. Writable context files were therefore synchronized under an account-prefixed storage key while the context viewer and workspace operations read the workspace-prefixed key.Verification
python3 -m pytest -q tests/test_e2b_artifact_collection.py: 32 passedruff check .: passedpython3 -m compileallon changed Python files: passedSafety review
Related read-path PR #2263 does not overlap this writeback scope fix.