feat(setup-repo): add agent selection, auto-detection, and project-co… - #18
feat(setup-repo): add agent selection, auto-detection, and project-co…#18florian101010 wants to merge 4 commits into
Conversation
…ntext.json as canonical output - Add Question 0 to setup-repo: users select which AI tools they use (Claude, Copilot, Jules, etc.) so only relevant files are generated (~8 for Claude-only vs 41 for all tools) - Add auto-detection table for test/lint/build commands from package.json, pyproject.toml, Cargo.toml, go.mod, and Makefile — no manual input required for standard stacks - Add Phase 1.5: write project-context.json as canonical first output before any instruction file, making it the durable record of setup decisions (validated by check-agent-context-sync.py) - Add "agents" field to project-context.example.json schema - Add repomix-output.xml to .gitignore (generated bundle, not source) - Update README Quick Start: clarify agent selection, auto-detection, and project-context.json flow; remove "optional" framing for project-context.json; note repomix-output.xml is not committed - Sync all changes across .claude/, .agents/, .agent/ SKILL.md copies and Copilot prompt https://claude.ai/code/session_01PZSeMAKkcRug1QH81MU1qh
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a significant improvement by allowing users to select which AI agents they use, and only generating the relevant configuration files. The auto-detection of commands is also a great addition. The changes across the documentation and skill definitions are comprehensive and mostly consistent.
However, there is a critical issue: the new agent selection feature breaks the scripts/check-agent-context-sync.py validation script. This script is hardcoded to check for all instruction files, but with this PR, some files may not be generated, causing the script to fail. This breaks the check-all.sh quality gate. The validation script needs to be updated to read the agents from project-context.json and only check for files corresponding to the active agents.
I've also left a couple of comments on markdown files to improve clarity and consistency.
Note: Security Review has been skipped due to the limited scope of the PR.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…text.json The hardcoded TARGETS list broke the quality gate when agent selection was used — files for inactive agents don't exist, so the script would always fail after a Claude-only or partial setup. GEMINI.md is now only checked when "gemini" or "jules" is active; .github/copilot-instructions.md only when "copilot" is active. AGENTS.md and CLAUDE.md remain always-checked ([ALL]). Fixes the critical issue raised in PR #18 review. https://claude.ai/code/session_01PZSeMAKkcRug1QH81MU1qh
…ntext.json as canonical output
https://claude.ai/code/session_01PZSeMAKkcRug1QH81MU1qh
PR-Checklist
Goal
Change Type
Scope
Implementation
Test Evidence
docs/QA-CHECKLIST.mdverified (if applicable)Details:
Documentation Impact (Required)
Affected doc files:
docs/README.mddocs/ARCHITECTURE.mddocs/CHANGELOG.mddocs/decisions/(ADR file, if architectural)Reason / Updated docs:
ADR Check
If required: ADR in
docs/decisions/created/updated?Definition of Done
AGENTS.md,CLAUDE.md,.github/copilot-instructions.md,.agent/rules/*)