Header product links: Flow Council, Flow Splitter, Flow QF - #347
Conversation
Replace the home page's For funders/builders/everyone header links with the product links, drop Flow Caster from the header, footer, and home page, and give the Flow QF docs page a full CTA to run a round.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gaston-review[bot]](https://avatars.githubusercontent.com/in/3010035?s=60&v=4){kind=small}
There was a problem hiding this comment.
Gaston Review
Verdict: Approved
Score: ████████░░ 8/10
Pull Request Summary
This PR replaces the split home/non-home header navigation with a unified "Flow Council / Flow Splitter / Flow QF" nav bar on all pages, removes all "Flow Caster" and "Beamr" links from the header, footer, and home page, and cleans up the now-unused query-param-based audience scrolling (?for-funders, ?for-builders, ?for-everyone). On the home page, Council and Splitter link to /launch; elsewhere they link to the index. Flow QF points to the docs site. The docs also get a new "Run a Flow QF round" section.
Review Summary
🔵 Suggestion — Flow Caster remnants outside this PR's scope
Flow Caster links are removed from header/footer/home, but src/app/api/flow-caster/ routes and src/app/explore/ references still exist. If Flow Caster is being sunset, those should be cleaned up in a follow-up.
Nice simplification. The old header had a bulky conditional duplicating structure for home vs non-home; the computed-href approach is cleaner and easier to maintain. The dead-code removal (query-param scrolling, unused imports) is thorough. No bugs, no security issues. The Flow Caster API routes and explore-page references still exist, but that's clearly out of scope for this nav-focused PR.
📌 1 inline comment
⚪ Nitpick: 1
🔍 Reviewed by Gaston
There was a problem hiding this comment.
Gaston Review
Verdict: Approved
Score: ████████░░ 8/10
Pull Request Summary
This follow-up push extracts the hardcoded Flow QF docs URL into a shared FLOW_QF_DOCS_URL constant in src/lib/constants.ts and replaces all three usages (Header, Footer, home page) with it. It also adds a "Run a Flow QF round" section to the docs, tweaks the existing tip callout copy, and completes the home-page cleanup from the prior push (removing Flow Caster/Beamr links and the query-param scrolling logic).
This addresses the nitpick from my first review about the duplicated docs URL. The constant is in the right place, all usages converge on it, and the docs addition is well-structured. Nothing to flag — the PR is clean.
🔍 Reviewed by Gaston
There was a problem hiding this comment.
Gaston Review
Verdict: Approved
Score: ████████░░ 8/10
Pull Request Summary
This PR unifies the header navigation across all pages to show "Flow Council / Flow Splitter / Flow QF," removes Flow Caster and Beamr links from header, footer, and home page, extracts the docs URL into a shared constant, cleans up the dead query-param scrolling code, and adds a "Run a Flow QF round" section to the docs. The latest commit fixes the product links to point at the grid pages (/flow-councils, /flow-splitters) instead of /launch.
Clean simplification across all three pushes. The header went from a bulky home/non-home conditional duplicating structure to a single unified nav bar with computed variables. The shared constant addresses my earlier nitpick. Dead code removal is thorough. No bugs, no security issues.
🔍 Reviewed by Gaston
1 participant
Replaces the audience links in the Home page header with the product links, removes Flow Caster, and gives the Flow QF docs page a real CTA (since Flow QF is the only product without a launch page, the header sends people to the docs).
Header
For funders/For builders/For everyone->Flow Council(launch page),Flow Splitter(launch page),Flow QF(docs).Flow Council/Flow Splitterkeep pointing at the product pages,Flow Casteris replaced byFlow QF.Flow Caster removal
?for-funders/?for-builders/?for-everyonedeep links on the Home page (the audience tabs themselves stay), and the Beamr link.Docs
docs/platform/flow-qf.mdgets a stronger top admonition (Telegram + email, "rounds aren't self-serve, we run them with you") and a new "Run a Flow QF round" section covering round design, applications & review, the round page, and donor/grantee support. The docs repo PR is autogenerated on merge.Verification
Drove the real header in a browser: home links land on
/flow-councils/launchand/flow-splitters/launch, app links on/flow-councilsand/flow-splitters, both mobile menus show the three products, and noFlow Casterstring remains in the header, footer, or home page. Built the Docusaurus site with the updated page (no broken links).pnpm typecheck,pnpm lint,pnpm prettierpass.