Fix: Optional Flow exception dump files for SentryStorage (storageLogging)#50
Open
Schuppel1 wants to merge 2 commits intoflownative:mainfrom
Open
Fix: Optional Flow exception dump files for SentryStorage (storageLogging)#50Schuppel1 wants to merge 2 commits intoflownative:mainfrom
Schuppel1 wants to merge 2 commits intoflownative:mainfrom
Conversation
Introduce a nullable FileStorage property in SentryStorage and add a new Flownative.Sentry.storageLogging config (default: false). Update README to document that Flow exception dump files are kept in Data/Logs/Exceptions/*.txt by default and show how to disable that behavior with `Flownative:\n Sentry:\n storageLogging: false`.
Member
|
Thanks! I'll have a look! I'll need to dig into my memory, but I would guess it wasn't an active decision to no longer write those files at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
flownative/sentryasNeos.Flow.log.throwables.storageClass, throwables are reported to Sentry, but Flow/Neos no longer writes exception dump files to Data/Logs/Exceptions/*.txt. This breaks the developer experience (“For a full stacktrace, open …”) because the referenced file may not exist.Solution
Flownative\Sentry\Log\SentryStoragenow optionally writes Flow exception dump files by delegating toNeos\Flow\Log\ThrowableStorage\FileStorage, while still capturing the throwable to Sentry.New setting (default: false)
Changes
•
Classes/Log/SentryStorage.phpFlownative.Sentry.storageLogging•
Configuration/Settings.yamlstorageLogging: falsedefault• README.md
Testing
• Configure SentryStorage as throwable storage and trigger an exception (storageLogging: true):
• Set storageLogging: false:
Environment
• PHP: 8.2
• flownative/sentry: 3.2.0
• sentry/sentry: ^4.0
• Neos Flow: 9.1