restore preserve_order on taurpc serde_json#16
Merged
Conversation
The rc.24 rebuild against upstream main collapsed the runtime crate's serde_json feature set to bare "1", losing preserve_order. The macros crate still has it, so codegen field order is deterministic at build time but any runtime serde_json::Map iteration falls back to BTreeMap sort. Match taurpc-macros and the workspace baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The rc.24 rebuild against upstream main (PR #15) collapsed the runtime
taurpccrate'sserde_jsonfeature set from["preserve_order"]to bare"1". Thetaurpc-macrossub-crate still pins["preserve_order"], so the inconsistency lives entirely in the runtime crate -- proc-macro codegen order is deterministic at build time, but anywhere taurpc actually walks aserde_json::Mapat runtime it falls back toBTreeMap's sorted iteration.This restores the feature so behavior matches both the macros crate and the workspace baseline (
fltsci/Cargo.tomlalready enablespreserve_orderworkspace-wide for the same reason -- the in-tree comment notes "GeoJson tests become non-deterministic without preserve_order").Test plan
cargo build -p taurpcclean