bump dprint to 2025 + relax operatorPosition#24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.50.2 -> 0.54.00.85.1 -> 0.96.00.17.4 -> 0.21.30.15.3 -> 0.21.10.4.3 -> 0.6.2binaryExpression/conditionalExpression/conditionalType.operatorPositionset tomaintaindprint fmtis a no-op onmainafter the bump -- no existing source files reformat. TheoperatorPosition: maintainchange makes dprint accept multi-line&&/||/ternary either at end-of-line or start-of-next-line, instead of forcing one. That removes a category of "works locally, fails CI" drift for external contributors.Effect on #22 after rebase
Of the 3 files #22 currently fails
dprint checkon:example/src/lib/testing.ts&&operator-position drift; now accepted bymaintain)taurpc/src/export.rsrustfmt --edition 2024let-chain layout drift, decided by whichrustfmtis on PATH (CI's vs Oscar's). Arust-toolchain.tomlpin in a follow-up would deterministically fix this categoryREADME.md"double"quotes; repoquoteStyleispreferSingle. Stylistic inconsistency in the contributed content. Either Oscar adjusts in his branch (small fix), or a follow-up adds<!-- dprint-ignore -->around the affected fences after rebaseSo: this PR unblocks one of the three drifted files. The other two are content/toolchain decisions, not config.
Test plan
pnpm installcleanpnpm lintclean (types + format + js)dprint fmtproduces zero diff onmain#22'stesting.ts&&-style passesdprint checkwith new config