add Rust toolchain setup to Release workflow#27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror the
dtolnay/rust-toolchainsetup step from.github/workflows/main.ymlinto.github/workflows/release.yml.Why
#26 pinned the Rust toolchain via
rust-toolchain.tomland added a setup step to the CI workflow. The Release workflow's "Sync formatting if necessary" step also runspnpm format->dprint fmt-> shells torustfmt, but had no setup step. The post-#26 Release run on main hit:```
error: component download failed for cargo-x86_64-unknown-linux-gnu:
could not rename 'downloaded' file from '...partial' to '...':
No such file or directory (os error 2)
```
Cause: dprint runs rustfmt on multiple files in parallel. With the toolchain not yet installed, each parallel rustfmt invocation triggered its own concurrent
rustupauto-install, racing on~/.rustup/downloads/*.partialrename. Pre-installing the toolchain in a serial setup step removes the race.Test plan
pnpm lintclean locallychangeset-release/mainsucceeds (this fix only takes effect on the next push to main, since this PR itself doesn't trigger a release)