fixup! build/oven: Fix build-deps command for a recipe with no deps#402
Open
rgonzalezfluendo wants to merge 33 commits intoemscriptenfrom
Open
fixup! build/oven: Fix build-deps command for a recipe with no deps#402rgonzalezfluendo wants to merge 33 commits intoemscriptenfrom
rgonzalezfluendo wants to merge 33 commits intoemscriptenfrom
Conversation
Pass the object and let it be modified by the config file
Use the general indent which is available on both packages, xml.etree and lxml.
The current status is (failures=1, errors=2, successes=108).
It was used on gcc/gcc-core as per a81a692 but is no longer used on any recipe.
The code was a safe path to avoid sources access a not set property This property belongs to the GitCache source itself. In fact, it was overwritten there with a different value.
* Rename build_dir to be consistent with what sources handle, config_src_dir. * Initialize and set the config_src_dir in the Source * Initialize and set the config_build_dir in the Build * Use a new var, sources_dir to refer to the place where the build system sources are located. * Always override config_build_dir so the Oven can shell into the correct path * Allow building into a folder different than the config_src_dir on Meson, CMake and Autotools
This will allow in-place projects without the need to actually fetch the sources. Now projects can be delivered with a cerbero recipe as part of the distfiles if required. Also, simplifies testing by having local projects and recipes.
diegonieto
approved these changes
Nov 26, 2024
01ac76b to
a5e4b52
Compare
77823a0 to
407a2fc
Compare
8ac672e to
f4d6fd6
Compare
0af63d3 to
febb844
Compare
febb844 to
f34f3a2
Compare
313a20a to
81f6f28
Compare
213ec03 to
5a778d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.