Support gcc 10+ toolchains in accessibility headers - #191
Merged
Conversation
gcc 9.2.0 (Tizen 6.0/6.5/8.0) compiles these headers as-is, gcc 10 and later do not. Verified clean at -std=c++17 -Werror against gcc 9.2.0 (arm, arm64, x64 sysroots), libstdc++ 10, 11, 12, 13 and gcc 14.2.0 (Tizen 11.0 arm64). AXEventGenerator::Iterator now matches the current Chromium implementation, which spells out the five iterator_traits typedefs instead of deriving from the deprecated std::iterator: https://source.chromium.org/chromium/chromium/src/+/main:ui/accessibility/ax_event_generator.h
Contributor
|
It seems that AXRange::Iterator in ax_range.h uses std::iterator. |
Member
Author
I added more commit. thanks |
seungsoo47
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gcc 9.2.0 (Tizen 6.0/6.5/8.0) compiles these headers as-is, gcc 10 and later do not. Verified clean at -std=c++17 -Werror against gcc 9.2.0 (arm, arm64, x64 sysroots), libstdc++ 10, 11, 12, 13 and gcc 14.2.0 (Tizen 11.0 arm64).
AXEventGenerator::Iterator now matches the current Chromium implementation, which spells out the five iterator_traits typedefs instead of deriving from the deprecated std::iterator: https://source.chromium.org/chromium/chromium/src/+/main:ui/accessibility/ax_event_generator.h