debugger: if controller has been disposed, leave showScriptLocation early - #9884
Merged
Conversation
Contributor
Author
|
WDYT, @bkonyi ? |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a check to verify if the CodeViewController has been disposed after an asynchronous operation before updating the scripts history. The reviewer points out that this check is too late to prevent exceptions from modifying other disposed ValueNotifiers inside _showScriptLocation and refreshCodeStatistics(), and suggests adding disposed checks immediately after the asynchronous calls in those methods.
Contributor
Makes sense to me! Asynchronous gaps are nefarious! |
bkonyi
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discovered by Gemini when I asked it to look through integration tests for causes of flakiness.