Removes unused code in DevTools app extensions/ and framework/ directories - #9909
Merged
Conversation
kenzieschmoll
marked this pull request as ready for review
July 22, 2026 00:13
kenzieschmoll
requested review from
bkonyi and
srawlins
and removed request for
a team
July 22, 2026 00:13
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables Dart Code Metrics analysis for the extensions and framework directories by removing them from the exclusion list in analysis_options.yaml. This led to cleaning up unused fields, constants, and adding ignore comments for false positives. Additionally, an assertion-based debug check in HomeScreen was refactored to use if (kDebugMode). Feedback was provided regarding a potential "setState() called after dispose()" exception in HomeScreen due to the asynchronous nature of _debugInitVmServiceCache, along with a suggestion to maintain consistency by updating another assertion to use if (kDebugMode).
srawlins
approved these changes
Jul 22, 2026
kenzieschmoll
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #9906
Chained on top of #9908