Update textmate grammar to latest version - #9920
Merged
Merged
Conversation
This updates the grammar to the latest version from https://github.com/dart-lang/dart-syntax-highlight and regenerates the goldens. (I have another upcoming change, but to simplify reviewing, I didn't want to mix it in with previous updates here)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Dart syntax highlighting configuration (dart_syntax.json) to version 1.5.0, introducing a new pattern for class identifiers with optional factory methods, updating the highlighting of the new keyword, and updating the corresponding golden test files. A review comment points out that the renaming of the new keyword scope from keyword.control.new.dart to keyword.new.dart requires a corresponding update in syntax_highlighter.dart to prevent highlighting issues.
srawlins
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the grammar to the latest version from https://github.com/dart-lang/dart-syntax-highlight and regenerates the goldens.
(I have another upcoming change, but to simplify reviewing, I didn't want to mix it in with previous updates here)