Run dcm check-unused-code on devtools_app_shared - #9934
Open
kenzieschmoll wants to merge 3 commits into
Open
Conversation
kenzieschmoll
requested review from
bkonyi and
srawlins
and removed request for
a team
July 30, 2026 18:35
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the analysis_options.yaml configuration to use workspace-relative paths for unused-code exclusions and adds file-level ignore rules for web-specific files in devtools_app_shared. Feedback on the changes highlights that other excluded paths for the inspector in analysis_options.yaml must also be updated with the packages/devtools_app/ prefix to prevent them from failing to match under the new workspace-relative path resolution.
kenzieschmoll
changed the title
dcm check-unused-code on devtools_app_shareddcm check-unused-code on devtools_app_shared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #9906
This PR also bumps the flutter version so that we can take advantage of this fix that allows specifying proper relative paths in workspace
analysis_options.yamlfiles.