Skip to content

[google_maps_flutter] Document tile cache flicker - #12315

Open
faheemabbas766 wants to merge 1 commit into
flutter:mainfrom
faheemabbas766:google-maps-document-clear-tile-cache-flicker
Open

[google_maps_flutter] Document tile cache flicker#12315
faheemabbas766 wants to merge 1 commit into
flutter:mainfrom
faheemabbas766:google-maps-document-clear-tile-cache-flicker

Conversation

@faheemabbas766

Copy link
Copy Markdown
Contributor

Updates GoogleMapController.clearTileCache documentation to explain that some platform implementations may remove current tiles before replacements are available, which can cause the tile overlay to flicker. The wording remains implementation-neutral so it also applies to third-party platform implementations.

Fixes flutter/flutter#189678.

Pre-Review Checklist

Test exemption: This PR changes only API documentation and the required release metadata; it does not change runtime behavior.

Validation:

  • dart format --output=none --set-exit-if-changed packages/google_maps_flutter/google_maps_flutter/lib/src/controller.dart
  • dart run script/tool/bin/flutter_plugin_tools.dart analyze --packages=google_maps_flutter/google_maps_flutter --exact-match-only
  • dart run script/tool/bin/flutter_plugin_tools.dart dart-test --packages=google_maps_flutter/google_maps_flutter --exact-match-only
  • dart run script/tool/bin/flutter_plugin_tools.dart validate --packages=google_maps_flutter/google_maps_flutter --exact-match-only --base-branch=upstream/main
  • dart run script/tool/bin/flutter_plugin_tools.dart publish-check --packages=google_maps_flutter/google_maps_flutter --exact-match-only

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the google_maps_flutter package to version 2.18.1. The changes update the documentation for the clearTileCache method in GoogleMapController to clarify that clearing the tile cache may cause the tile overlay to flicker on some platforms. The CHANGELOG.md and pubspec.yaml files have been updated accordingly. There are no review comments to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[google_maps_flutter] Document that clearTileCache() may cause flickering

1 participant