[vector_graphics] Error handling enhancement#8061
[vector_graphics] Error handling enhancement#8061minhhung2556 wants to merge 5 commits intoflutter:mainfrom
Conversation
- copy from this PR: dnfield/vector_graphics#258
# Conflicts: # packages/vector_graphics/CHANGELOG.md # third_party/packages/flutter_svg/CHANGELOG.md
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
jonahwilliams
left a comment
There was a problem hiding this comment.
Can you be more specific about what you mean by "enhance"?
This also needs a test
Hi, this PR changed the method _loadPicture to check some cases that could cause an error, such as: can not load the vector file, vector byte data is empty, and decodeVectorGraphics throws an exception. |
|
From triage: what is the status of this PR? It sounds like there's still some resolution needed as to whether this PR requires new tests. |
|
I don't think this change meets the quality bar for the package. |
Purpose
To fix these related issues below
My related PRs
Changes Made
Testing
Impact
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.