Correct HelmChart status.url description#2091
Closed
alliasgher wants to merge 1 commit into
Closed
Conversation
The HelmChartStatus.URL doc-comment recommended using BucketStatus.Artifact, which belongs to the Bucket API. Point it at HelmChartStatus.Artifact in both v1 and v1beta2, and regenerate the HelmChart CRD. Signed-off-by: alliasgher <alliasgher123@gmail.com> Assisted-by: Claude Code/claude-opus-4-8
matheuscscp
added
bug
matheuscscp
reviewed
Jun 28, 2026
matheuscscp
left a comment
matheuscscp
left a comment
Member
There was a problem hiding this comment.
Please rebase and force-push after fixing the comments 🙏 Don't use the "merge main" button
|
|
||
| // +genclient | ||
| // +kubebuilder:object:root=true | ||
| // +kubebuilder:resource:shortName=hc |
Member
There was a problem hiding this comment.
Please remove this line from the v1beta2 file
| // URL is the dynamic fetch link for the latest Artifact. | ||
| // It is provided on a "best effort" basis, and using the precise | ||
| // BucketStatus.Artifact data is recommended. | ||
| // HelmChartStatus.Artifact data is recommended. |
Member
|
Actually, this bug is already fixed in the main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HelmChartStatus.URLdoc-comment recommends consultingBucketStatus.Artifact, which belongs to theBucketAPI, notHelmChart. The generatedhelmchartsCRD inherits this wrong reference in thestatus.urlfield description.Point the comment at
HelmChartStatus.Artifactin bothapi/v1andapi/v1beta2, and regenerate the CRD. Comment-only change with the regenerated manifest; no functional or schema-shape impact.This is the source-controller portion of fluxcd/flux2#5941 (the image-reflector-controller and image-automation-controller findings in that issue live in their own repos).
Verified with
make manifests fmt vetand the api module tests.Assisted-by: Claude Code/claude-opus-4-8