fix(benchmarks): keep several round fold labels on the sweep colourbar at small --clip#32
Merged
Merged
Conversation
…mall --clip The fold colourbar placed ticks at integer log2 steps (…, 1/2×, 1×, 2×, …). For a tight range — a small `--clip` like 1.5 (bound = log2 1.5 ≈ 0.585), or a naturally tight p95 default — those integer steps fall *outside* [-bound, bound], so only `1×` rendered. Pick ticks that fit the range and read as round folds: clean powers of two for a wide range, round sub-2× folds (1.5×, 1.25×, 1.1×) for a tight one, with an even-spaced fallback when nothing round fits. `--clip 1.5` now shows 1/1.5× … 1.5× instead of a lone 1×. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO (human): one line on why.
Note
Generated by AI (Claude).
What
The sweep heatmap's fold colourbar placed ticks at integer log₂ steps (…,
1/2×,1×,2×, …). For a tight colour range — a small--cliplike 1.5 (bound = log₂1.5 ≈ 0.585), or a naturally tight p95 default — those integer steps fall outside[-bound, bound], so only1×rendered.Now ticks fit the range and read as round folds: clean powers of two for a wide range, round sub-2× folds (
1.5×,1.25×,1.1×) for a tight one, with an even-spaced fallback when nothing round fits.--clip 1.5→1/1.5×, 1/1.25×, 1/1.1×, 1×, 1.1×, 1.25×, 1.5×instead of a lone1×.Verify
_fold_ticksgives in-range, symmetric labels across--clip1.1 / 1.5 / 2 / 8 and default p95 bounds.