Fix: filter out merged and closed submissions from TUI review lane fallback

[flyingrobots]

Resolves the issue where finished and fully merged or closed submissions would show up in the TUI review lane when falling back to snapshot.submissions.

Summary by CodeRabbit

• Tests
  • Added test suite validating review lane filtering behavior and submission status handling.
• Bug Fixes
  • Review lane submission filtering updated to exclude MERGED and CLOSED items, ensuring only active submissions appear in the review queue for user attention.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1ebe5911-7173-41e1-a0fb-a28f5fa8cdf6

📥 Commits

Reviewing files that changed from the base of the PR and between ea45a12 and 0d3e4e0.

📒 Files selected for processing (2)

• src/tui/bijou/__tests__/views.test.ts
• src/tui/bijou/cockpit.ts

---

📝 Walkthrough

Walkthrough

A one-line status filter is added to cockpit.ts in the 'review' lane fallback path so that submissions with MERGED or CLOSED status are excluded before mapping and sorting. A new test suite in views.test.ts validates this filtering via buildLaneTable.

Changes

Review Lane Status Filter

Layer / File(s)	Summary
Filter MERGED/CLOSED submissions and test src/tui/bijou/cockpit.ts, src/tui/bijou/__tests__/views.test.ts	cockpit.ts adds a .filter() call on snapshot.submissions to drop MERGED and CLOSED entries before building cockpit items in the review lane fallback. The new test constructs a three-submission snapshot (OPEN, MERGED, CLOSED) and asserts buildLaneTable returns exactly one row for the OPEN submission.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit checks the lane each day,
merged and closed must fade away.
Only OPEN gets to stay,
hopping through without delay!
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and accurately describes the main change: filtering merged and closed submissions from the TUI review lane fallback, which is the core change across both test and implementation files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cycle/review-tab-merged-filter

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}