Conversation
Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: Yicheng-Lu-llll <luyc58576@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #890 +/- ##
==========================================
- Coverage 54.62% 54.61% -0.02%
==========================================
Files 585 585
Lines 15316 15321 +5
Branches 2801 2803 +2
==========================================
+ Hits 8366 8367 +1
- Misses 6950 6954 +4 ☔ View full report in Codecov by Sentry. |
3 tasks
Signed-off-by: Future-Outlier <eric901201@gmail.com>
e8ec978 to
2e5864b
Compare
Signed-off-by: Lyon Lu <lyon@union.ai>
2f36663 to
24afebc
Compare
Signed-off-by: Lyon Lu <lyon@union.ai>
24afebc to
290f3ae
Compare
3 tasks
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Carina Ursu <carina@union.ai>
ursucarina
approved these changes
Jan 30, 2025
|
Congrats on merging your first pull request! 🎉 |
Collaborator
|
🎉 This PR is included in version 1.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Show flyte deck when running phase and terminal phase (include failed)
Type
Are all requirements met?
Complete description
This pull request (PR) introduces several enhancements and fixes to the FlyteDeckButton and ExecutionNodeDeck components in the Flyte console. Here's a summary of the changes:
FlyteDeckButton Component:
RefreshIconbutton to allow users to refresh the deck content.useDownloadLinkhook to manage the download link for the deck.disabledstate from the button that opens the deck, allowing it to be clicked regardless of the node execution phase.ExecutionNodeDeckcomponent to accept adownloadLinkprop.ExecutionNodeDeck Component:
NotFoundErrorto display a user-friendly message when the deck is not yet available.downloadLinkprop instead of creating a new instance within the component.This PR enhances the FlyteDeckButton and ExecutionNodeDeck components to improve user interaction and error handling.
Tracking Issue
Follow-up issue
NA
Example
NEW FLYTEKIT, NO DECK, RUNNING With Deck, SUCCEED, and FAILED
OSS-STREAMING-DECK-small.mov
OLD FLYTEKIT, NO DECK, RUNNING With Deck, SUCCEED, and FAILED
OSS-STREAMING-DECK-OLD-FLYTEKIT-small.mov