Add project and domain filters in order to hit DB index #patch#891
Merged
EngHabu merged 1 commit intoflyteorg:masterfrom May 5, 2025
Merged
Add project and domain filters in order to hit DB index #patch#891EngHabu merged 1 commit intoflyteorg:masterfrom
EngHabu merged 1 commit intoflyteorg:masterfrom
Conversation
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: Michael Ruoss <michael.ruoss@cradle.bio>
mruoss
force-pushed
the
fix-performance-issues
branch
from
96cbaab to
f3118eb
Compare
EngHabu
approved these changes
May 5, 2025
|
Congrats on merging your first pull request! 🎉 |
Collaborator
|
🎉 This PR is included in version 1.20.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
This addresses the issue described in flyteorg/flyte#6428 where DB queries don't use the indexes on the
workflows,tasksandlanuchplanstable. This slows down the UI significantly and spikes the CPU usage of the database server.Type
Are all requirements met?
Complete description
The index in the database is over the three columns
(name, project, domain)- not JUSTname. Therefore when filtering, we need to pass all these values in order to leverage the index.Tracking Issue
fixes flyteorg/flyte#6428