defensive line length check in config validator#64
Open
jvoigtlaender wants to merge 1 commit into
Open
Conversation
(to be prepared for whitespace watermarking in the template and line-outcomments in the sample solution)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the configuration-time line-length validation for the template module and the (optional) sample solution to anticipate later transformations (e.g., whitespace watermarking and line-outcommenting) without exceeding the configured maxLineLength.
Changes:
- Validate the template module using
maxLineLength - 1to reserve 1 character per line. - Validate the sample solution using
maxLineLength - 3to reserve 3 characters per line.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be prepared for whitespace watermarking in the template and line-outcomments in the sample solution.