Add gcassert:noescape annotations to RefPointer methods#10
Merged
Conversation
fmstephe
force-pushed
the
test-gcassert
branch
2 times, most recently
from
d78302c to
c4478e0
Compare
Each of these methods have a pointer receiver. But RefPointer is used as a value, so it's important that the receiver does not escape to the heap. If it does escape then each method call(!) will allocate to the heap. As a side note, the rationale behind using a pointer receiver is to avoid copying two words on RefPointer method calls. This rationale makes sense, but hasn't been tested as a performance improvement. In the future we should test this. Maybe value receivers are just as good (or better).
At this time this fork of gcassert detects leaking parameter messages indicating that a parameter has escaped to the heap. Remove gcassert if it exists rm rm Use version v0.0.3 of my gcassert fork
fmstephe
force-pushed
the
test-gcassert
branch
2 times, most recently
from
5bad08e to
325af59
Compare
Because the handler is passed into a fmt.Errorf(...) call on an error path the handler is forced to be on the heap. We take the value of the handler to avoid this. This error was picked up by the gcassert:noescape annotation. Very satisfying.
fmstephe
force-pushed
the
test-gcassert
branch
from
325af59 to
3d62741
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives us confidence that these method call don't allocate.