Ensure correct numerical sorting of TOC when chapters exceed 10#73
Open
adiprnm wants to merge 3 commits intofnando:mainfrom
Open
Ensure correct numerical sorting of TOC when chapters exceed 10#73adiprnm wants to merge 3 commits intofnando:mainfrom
adiprnm wants to merge 3 commits intofnando:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the order of the TOC when there are more than 10 chapters, so the generated HTML would be like this:
The
write_toc!depends on the order of the section's HTML, thus wrong ordering results in an invalid ToC ordering.PR Checklist
PR Structure
PRs).
two PRs otherwise).
Thoroughness
fixes.
.mdfiles, etc… affected by this change.What
Why
It's a bug that needs to be solved.
Known limitations
N/A