Skip to content

au: fix Anzac Day moving conditions for NSW and SA#975

Merged
derTobsch merged 1 commit intofocus-shift:mainfrom
kirbyfu:au-anzac-day-nsw-sa-fix
Mar 31, 2026
Merged

au: fix Anzac Day moving conditions for NSW and SA#975
derTobsch merged 1 commit intofocus-shift:mainfrom
kirbyfu:au-anzac-day-nsw-sa-fix

Conversation

@kirbyfu
Copy link
Copy Markdown
Contributor

@kirbyfu kirbyfu commented Mar 31, 2026

Summary

Context

Anzac Day 2026 (April 25) falls on a Saturday. NSW now provides an additional public holiday on Monday April 27. SA confirmed they will not follow suit.

State Sat sub Sun sub Status
NSW Yes (from 2026) Yes (from 2026) Fixed in this PR
SA No (from 2023) No (from 2023) Fixed in this PR
ACT Yes Yes Already correct
WA Yes Yes Already correct

Test plan

  • Added targeted tests for NSW Anzac Day substitute on Saturday (2026) and Sunday (2027)
  • Added boundary test confirming NSW has no substitute before 2026
  • Added test confirming SA has no substitute for Saturday (2026) or Sunday (2027)
  • Added ACT regression test
  • Existing validateCalendarData property test (2019–2022) continues to pass

NSW: Add Saturday and Sunday substitute (Monday) from 2026, per the
Public Holidays Act 2010 (NSW) amendment effective 2026.

SA: Cap Sunday substitute at 2022. The Public Holidays Act 2023 (SA)
removed Anzac Day weekend substitution from 2023 onward.

Co-Authored-By: Claude <noreply@anthropic.com>
@derTobsch derTobsch force-pushed the au-anzac-day-nsw-sa-fix branch from 092dd28 to 6cf055f Compare March 31, 2026 09:52
@derTobsch derTobsch merged commit 2ee9a2e into focus-shift:main Mar 31, 2026
13 checks passed
@derTobsch derTobsch added this to the 2.5.0 milestone Mar 31, 2026
@kirbyfu kirbyfu deleted the au-anzac-day-nsw-sa-fix branch March 31, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants