Skip to content

MODLD-913: Make the label of CONCEPT resource predictable#152

Merged
pkjacob merged 1 commit intomasterfrom
pjacob/MODLD-913
Feb 19, 2026
Merged

MODLD-913: Make the label of CONCEPT resource predictable#152
pkjacob merged 1 commit intomasterfrom
pjacob/MODLD-913

Conversation

@pkjacob
Copy link
Contributor

@pkjacob pkjacob commented Feb 17, 2026

Make the label of CONCEPT resource predictable by having this format
focus label -- topic subfocus label -- place subfocus label -- temporal subfocus label -- form subfocus label

Copilot AI review requested due to automatic review settings February 17, 2026 19:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CONCEPT label generation to produce a deterministic, domain-specific ordering of FOCUS/SUB_FOCUS components so label output is predictable.

Changes:

  • Replaced ad-hoc edge sorting with a dedicated comparator for CONCEPT outgoing edges.
  • Introduced SUB_FOCUS ordering by type precedence (TOPIC → TEMPORAL → PLACE → FORM) and case-insensitive label sorting.
  • Updated/expanded the CONCEPT label generator test to validate the new ordering behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/main/java/org/folio/ld/dictionary/label/generators/ConceptLabelGenerator.java Adds a custom comparator to enforce consistent ordering of FOCUS/SUB_FOCUS edges when building CONCEPT labels.
src/test/java/org/folio/ld/dictionary/label/ConceptLabelGeneratorTest.java Updates the test fixture and expected output to assert the new deterministic ordering for SUB_FOCUS elements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 17, 2026 21:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 18, 2026 14:13
@sonarqubecloud
Copy link

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pkjacob pkjacob merged commit 9270f63 into master Feb 19, 2026
11 checks passed
@pkjacob pkjacob deleted the pjacob/MODLD-913 branch February 19, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants