Draft
Conversation
|
There was a problem hiding this comment.
Pull request overview
Adds support for generating human-readable labels for Title-like resources (Title/Variant/Parallel/Abbreviated) based on structured title properties in the resource doc, and refactors shared JSON-property extraction into a helper.
Changes:
- Introduces
TitleLabelGeneratorto build a label frommainTitle,subTitle,partNumber, andpartName. - Extracts reusable JSON
docproperty lookup intoLabelHelperand reuses it inHubLabelGenerator. - Registers the new generator in
LabelGeneratorServiceand adds unit tests covering spacing/missing-property behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/org/folio/ld/dictionary/label/TitleLabelGeneratorTest.java | Adds tests verifying title label composition and spacing behavior. |
| src/main/java/org/folio/ld/dictionary/label/generators/TitleLabelGenerator.java | Implements title label generation by joining available title properties. |
| src/main/java/org/folio/ld/dictionary/label/generators/HubLabelGenerator.java | Refactors property extraction to use the shared helper. |
| src/main/java/org/folio/ld/dictionary/label/LabelHelper.java | Adds shared helper for reading the first string value from a JSON doc property. |
| src/main/java/org/folio/ld/dictionary/label/LabelGeneratorService.java | Registers TitleLabelGenerator in the generator chain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.