UISAUTHCOM-97 Add Role Name validation to RoleForm. - #150
Merged
Conversation
JohnC-80
changed the title
JohnC-80
marked this pull request as ready for review
August 6, 2026 13:22
BogdanDenis
approved these changes
Aug 7, 2026
Dmytro-Melnyshyn
approved these changes
Aug 7, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UISAUTHCOM-97
Purpose
The backend will error if a Role name includes a forward slash ("/") So we validate that it has one, maintaining the validation that the name field is required.
Approach
This validation was implemented in vanilla JS. This form does not use stripes-final-form, and any conversion will be work for a separate PR.
The story says to hold off on validating the field until blur, but it's better to display the message sooner. The instant the form updates with a bad value, they user will be unable to submit.
TODOS and Open Questions
New UI behavior:
2026-08-06_09h04_35.mp4