UISAUTHCOM-96 (Sunflower BF) Some capabilities not shown when editing a role but shown in its detail view - #153
Draft
JohnC-80 wants to merge 5 commits into
Draft
UISAUTHCOM-96 (Sunflower BF) Some capabilities not shown when editing a role but shown in its detail view#153JohnC-80 wants to merge 5 commits into
JohnC-80 wants to merge 5 commits into
Conversation
…plications to the Role Edit view
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UISAUTHCOM-96
Purpose
The Role Edit page is missing application entries that are present on the Role Details page.
Approach
Added another call of
useRoleCapabiliteswithexpand=trueto fill outcapabilitiesAppIdsfrom the associated, inherited capabilities, not exclusively the directly selected capabilities.If https://folio-org.atlassian.net/browse/MODROLESKC-408 is backported, this will be unnecessary, since the directly assigned capabilities can be discerned from the inherited ones in a single call with
expand=true.Check/uncheck behavior of Capability Sets is maintained and persists.
Adding
isFetchingto output from hooks so that we can wait for initial data to be loaded.The capabilities endpoint in >= Trillium includes the
directfield on capabilities, so it's must easier for the UI to distinguish directly-assigned capabilities vs inherited ones.Tests updated to reflect the current state of the code.
Bugfix: (Same apps showing up in tables on Edit screen as appear on the Details view.)
2026-08-13_09h22_47.mp4
Capability Sets selection/deselection:
2026-08-13_09h59_34.mp4
Re-edit
2026-08-13_10h02_19.mp4
Inherited/direct-assignment Capabilities
2026-08-13_10h06_00.mp4