UIOR-1569: Correct refresh of prefix and suffix fields by charismatic-claire · Pull Request #1875 · folio-org/ui-orders

charismatic-claire · 2026-07-21T11:57:09Z

Purpose

https://folio-org.atlassian.net/browse/UIOR-1569

This is a bugfix for the following problem: Prefix and suffix do not correctly refresh on selection in the create and edit of a Purchase Order.

Approach

How did we solve this? Well, FieldPrefix and FieldSuffix contained broken validation logic, s.t. we could run into cases where we need to validate fields that aren't present. To fix that, we put the condition shouldRevalidatePoNumber in place, taking care of that cases. That makes sure we only run the validation when poNumber was mounted and is actually present, s.t. it can really be used for validation.

github-actions · 2026-07-21T12:00:59Z

Jest Unit Test Results

1 files ±0 307 suites ±0 6m 50s ⏱️ -1s
1 138 tests +4 1 130 ✅ +4 8 💤 ±0 0 ❌ ±0
1 146 runs +4 1 138 ✅ +4 8 💤 ±0 0 ❌ ±0

Results for commit a7a39ae. ± Comparison against base commit 820d529.

This pull request removes 2 and adds 6 tests. Note that renamed tests count towards both.

FieldPrefix should render 'prefix' field ‑ FieldPrefix should render 'prefix' field
FieldSuffix should render 'suffix' field ‑ FieldSuffix should render 'suffix' field

FieldPrefix should not validate PO number when shouldValidate is false ‑ FieldPrefix should not validate PO number when shouldValidate is false
FieldPrefix should render the prefix field ‑ FieldPrefix should render the prefix field
FieldPrefix should validate PO number when shouldValidate is true ‑ FieldPrefix should validate PO number when shouldValidate is true
FieldSuffix should not validate PO number when shouldValidate is false ‑ FieldSuffix should not validate PO number when shouldValidate is false
FieldSuffix should render the suffix field ‑ FieldSuffix should render the suffix field
FieldSuffix should validate PO number when shouldValidate is true ‑ FieldSuffix should validate PO number when shouldValidate is true

♻️ This comment has been updated with latest results.

elsenhans · 2026-07-22T11:59:14Z

Please add ticket to CHANGELOG.md

charismatic-claire · 2026-07-23T07:53:29Z

@elsenhans Do you like the changes?

elsenhans · 2026-07-23T09:35:28Z

@elsenhans Do you like the changes?

Looking good. Thanks for the additional test case.
Some small points:

Seems like line 20 is unused:
const React = jest.requireActual('react');
Please remove it.
Fix eslint errors in FieldPrefix.test.js and FieldSuffix.test.js

NikitaSedyx

please address linter issues

additionally I didn't get how validation exclusion when po number is present solves your issue, I believe you just need to make component rerender and do not touch validation

charismatic-claire · 2026-07-23T10:38:51Z

@elsenhans Thanks for finding this, I'll address the issue.
@NikitaSedyx I will address the linter issues. On your second question: I think the thrown exceptions due to the throwing validation (because it cannot grab the value to validate) IS THE CAUSE of the issue of the field not refreshing properly. See the video attached. Otherwise I wouldn't expect that an input field update requires a manual refresh. The reactive nature of, well... React, should take care of that. I think.

Screencast_20260723_123408.webm

charismatic-claire · 2026-07-23T10:55:48Z

@elsenhans I adressed your comments.

@NikitaSedyx I fixed all the linter issues including two unrelated ones. I added an extra commit for it to indicate the fix doesn't belong to the ticket itself.

charismatic-claire · 2026-07-23T11:47:10Z

  );

-  useEffect(refreshList, [lineId]);
+  useEffect(refreshList, [lineId, refreshList]);


@NikitaSedyx out of scope linter fix in extra commit. If that's considered bad practice, we can remove it.

charismatic-claire · 2026-07-23T11:47:24Z

      }));
    }
-  }, []);
+  }, [initialValues.template, parentResources?.orderTemplates?.records]);


@NikitaSedyx out of scope linter fix in extra commit. If that's considered bad practice, we can remove it.

I would suggest to not fix issues not connected to your changes

NikitaSedyx · 2026-07-23T12:28:35Z

I think the thrown exceptions due to the throwing validation (because it cannot grab the value to validate) IS THE CAUSE of the issue of the field not refreshing properly. See the video attached. Otherwise I wouldn't expect that an input field update requires a manual refresh. The reactive nature of, well... React, should take care of that. I think.

hm, in some extent it makes sense, but I would like to play a bit - it's pretty old code so I do not remember all details

charismatic-claire · 2026-07-27T07:21:59Z

@NikitaSedyx did you take a look and could reproduce the bug and verify the fix?

We add a 'shouldValidate' property to 'FieldPrefix' and 'FieldSuffix', which is used to determine whether validating the input should be done or not. This way we do not validate if the 'poNumber' is not editable and hence accessible to the validators.

sonarqubecloud · 2026-08-06T08:25:35Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

elsenhans

LG

charismatic-claire changed the title ~~UI or 1569 correct refresh of prefix and suffix~~ UIOR-1569: Correct refresh of prefix and suffix fields Jul 22, 2026

charismatic-claire force-pushed the UIOR-1569-correct-refresh-of-prefix-and-suffix branch from 65ef658 to 026f5f2 Compare July 22, 2026 11:39