UIOR-1530 Fix payment terms accordion error state - #1878
Merged
Conversation
|
SerhiiNosko
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
Follow-up bug fixes for the Payment Terms form introduced in
UIOR-1530.
Amountthe default distribution type;omitFieldArraysAsyncErrorscorrectly stripped the pending Promise frompaymentTerms.fiscalYearDistributions, but left the now-emptypaymentTerms: {}object in the errors map.useErrorAccordionStatusiteratesObject.keys(errors)and treats that empty object as a real error, keeping the accordion in the error state indefinitely.Approach
Accordion false error state
Extended
omitFieldArraysAsyncErrorsto walk up the ancestor chain afterunsetting a nested path and remove any objects that are now empty. This ensures
{ paymentTerms: {} }is cleaned up alongsidepaymentTerms.fiscalYearDistributionsduring the async-pending window. Thewalk stops as soon as a non-empty ancestor is found, so real sibling errors
(e.g.
paymentTerms.totalPrice) are preserved.The function was also refactored into named, single-responsibility helpers
(
hasPendingArrayError,hasResolvedItemErrors,isEmptyObject,pruneEmptyAncestors) to make the logic easier to follow and test.POLineFormwas updated to use theuseFormState()hook instead ofform.getState()?.errorsso that the error map re-renders reactivelywhenever final-form state changes.
Pre-Merge Checklist