Conversation
bvsharp
approved these changes
Aug 11, 2026
# Conflicts: # CHANGELOG.md
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



mod-fqm-managerreportsdataType: "marcType"for every synthetic MARC column, regardless of whether it's a tag-only reference, a subfield, or an indicator target — so the frontend can't tell these apart from the reporteddataTypealone. This PR derives the correct operator set from the MARC field's name instead.parseMarcSelector(fieldName)inmarcFieldOperators.js, which parses a MARC field name (e.g.marc_245_ind1,marc_245_a,marc_245_ind1_1_ind2) into a{ subfield, indicator1, indicator2 }shape, mirroring the grammar used bylib-fqm-query-processor'sMarcFieldFactory. Handles:marc_bib.marc_245_a)isMarcIndicatorTargetclassifies a parsed selector as targeting an indicator (a single coded character) vs. a subfield/tag.eq/ne/in/nin(noempty, since an indicator always holds a value)getOperatorOptions(selectOptions.js) now accepts a rawfieldNameand internally callsparseMarcSelectorforMarcTypefields, replacing the two call sites inquery.jsandRepeatableFields.jsthat previously duplicated the samedataType === DATA_TYPES.MarcType ? parseMarcSelector(...) : undefinedgating check.getDiscreteOrTextOperatorsinconstants/operators.js— the sharedeq/ne+ (in/ninorcontains/starts_with) +emptyshape reused by bothStringType(viahasSourceOrValues) andMarcType(viaisMarcIndicatorTarget).MarcTypetoDATA_TYPES.Refs: UIPQB-277