fix(picker): correct Windows platform check for the find command#2687
Open
glmlm wants to merge 1 commit intofolke:mainfrom
Open
fix(picker): correct Windows platform check for the find command#2687glmlm wants to merge 1 commit intofolke:mainfrom
find command#2687glmlm wants to merge 1 commit intofolke:mainfrom
Conversation
|
Would be great to see this merged! In my case it resulted in an error message, since it tried to run the "find" program, which behaves differently on Windows. With this fix, it instead prompts the user to install fd/ripgrep/something else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix invalid enable check for the
findcommand that always evaluated to true.Related Issue(s)
N/A
Screenshots
N/A