Conversation
src/jesse_state.erl
Outdated
There was a problem hiding this comment.
According to Elvis:
Invalid macro name schema_loader_fun on line 49. Use UPPER_CASE.
There was a problem hiding this comment.
According to Elvis:
Missing space after "," on line 263
|
oh wow :) now I have 3 PRs (this, #5 and #2) to look into around $ref @emmmile @jamesaimonetti @emfa - could I kindly ask of you to provide some input on one another? without looking at all into the PRs, @emmmile or @emfa (both building on top of @jamesaimonetti) could get some inspiration from each other (completeness, correctness, etc), and update this PR or #5, so that I close the other two. NOTE: @emfa's work in #5 builds up on #4 as well, so accepting #5 would maybe make things easier. I'm not hinting at anything, nor being biased, just stating the less obvious. |
|
@andreineculau actually you are right, sorry for having not checked #5 before. #5 seems to cover all the cases, and it passes all the tests, so I guess that is the important thing. There is a lot of additional code for draft 04, but for what concerns draft 03 the work of @emfa looks good to me. So I would close this one, and work on #5. |
4 participants
Some modifications on top of the work from @jamesaimonetti (mostly added local URI decoding and support for refs to array elements).