@W-20113791 Update flexipage skill to reflect best practices#46
@W-20113791 Update flexipage skill to reflect best practices#46eclapham wants to merge 2 commits intoforcedotcom:mainfrom
Conversation
| @@ -0,0 +1,16 @@ | |||
| # fieldSection | |||
There was a problem hiding this comment.
From this thread I understand that we have different version of flexipaged skills in 260 and 262. Will this impact 260 version for TDX demo?
There was a problem hiding this comment.
There is no differentiation between release versions in skills, yet. So if this PR is merged it will impact 260, as it will impact any user of Vibes leveraging our skills.
There was a problem hiding this comment.
Are we planning to merge this PR before TDX demo is recorded?
I am asking this question since I believe we do not want to break TDX demo and there is another bug raised by Hemant that needs to be fixed before TDX demo.
There was a problem hiding this comment.
None of these changes are strictly required for TDX. This is why we need some concept of a release version for these skills :) I moved this to draft. I was intending to merge this before TDX, but I don't have a way of predicting what impact it will have on the TDX demos. Since those are sensitive, I'll hold off on this.
| ```xml | ||
| <componentInstanceProperties> | ||
| <name>columns</name> | ||
| <value>Facet-{uuid}</value> |
There was a problem hiding this comment.
You know better than me -- is the value for columns just a single facet? It might be helpful to expand this example a little bit, though I do appreciate you keeping it nice and tight. I'm just looking at this as a human and wondering if I have enough context to know how to define a field section just with this.
There was a problem hiding this comment.
Yeah, it points to a facet that contains flexipage:column components, whose bodies are yet another facet full of fields.
There may be room for improvement here, but FWIW this was copied from our existing knowledge here https://falcon.devhub.internal.salesforce.com/aihub/code-search/gitcore.soma.salesforce.com/core-2206/core-262-public@p4/262-main-91876e744bcf4f51e0b5c186a9a138f2b28c2afc/-/blob/core/flexipage-ai-impl/java/resources/experts/FlexiPage/knowledge.md?q=repo%3Agitcore.soma.salesforce.com%2Fcore-2206%2Fcore-262-public+file%3Acore%2Fflexipage-ai-impl%2Fjava%2Fresources%2Fexperts%2FFlexiPage%2F+knowledge.md&patternType=literal&view=code&L=242
| </itemInstances> | ||
| ``` | ||
|
|
||
| **Identifier Pattern:** `flexipage_richText` or `flexipage_richText_{sequence}` |
There was a problem hiding this comment.
This references back to the algo for generating unique ids, so each subsequent richText cmp would get a different identifier. I didn't think about this now being out of context. Honestly, we shouldn't need to have this specific to richText, since this is the same rule for all cmps. Let me see if I can remove this, and ensure it's clear in the main skill since it applies everywhere.
| --secondary-fields Phone,Industry,AnnualRevenue | ||
| ``` | ||
|
|
||
| CLI generates Facets with field references automatically. |
There was a problem hiding this comment.
Do we want to consider these component docs separate from knowledge about how to use the CLI? one concern is that if the only advice for configuring dynamicHighlights is to use the CLI, it may overwrite a previously generated page. I feel like we should have two sections here:
- How to create a new record page with dynamic highlights with the CLI
- How to configure/edit an existing record page with dynamic highlights (or how to replace the old highlightsPanel).
There was a problem hiding this comment.
We also don't include the full CLI command, so that could be interesting if there ultimately are multiple CLI commands
There was a problem hiding this comment.
This is a great callout. Originally this was in the knowledge, in the context of the other instructions. Now it's not. I agree we should split this up. I think the CLI instructions should remain in the main skill, and then these instructions would be outside that initial bootstrap. I don't know how often users would need to add a highlights cmp (since it should get bootstrapped or already exist), but editing instructions could be useful, and we can focus on those here. Let me take another pass at this.
|
|
||
| ```bash | ||
| sf project deploy start --source-dir force-app/main/default/flexipages | ||
| ``` |
There was a problem hiding this comment.
@eclapham Can we replace this with the dry run command?
cc: @vratan-sf @hsinghbisht-sfdc @ayushgupta-sf
4 participants
References: Contributing guide · Skill authoring guide · Agent Skills spec
What changed
@W-20113791@
Updating Flexipage skill to reflect best practices.
Updating Flexipage skill to include specific guidance for dynamicRelatedList component.
Why
The Flexipage skill now adheres to best practices. The Flexipage skill can now reliably configure DRL components when requested.
Notes
Best practices review notes from this PR were used: #25
Skills
Manual checklist
Description quality
Instructions
Context efficiency
templates/,examples/, ordocs/subdirectoriesAutomated checks
Enforced by CI (
npm run validate:skills) per the Agent Skills spec:SKILL.mdnamematches directory name;descriptionis present, ≥ 20 words, ≤ 1024 characters, and includes trigger language