This repository was archived by the owner on Feb 12, 2022. It is now read-only.
Fix Typo in CircleCI configuration#7
Open
jfeng-salesforce wants to merge 2 commits intoforcedotcom:masterfrom
Open
Fix Typo in CircleCI configuration#7jfeng-salesforce wants to merge 2 commits intoforcedotcom:masterfrom
jfeng-salesforce wants to merge 2 commits intoforcedotcom:masterfrom
Conversation
According to to the Readme.MD file, the SFDX user should be stored in $HUB_SFDX_USER, but the config.yaml file is checking the $HUB_SFDC_USER (SFDC instead of SFDX).
|
Thanks for the contribution! Before we can merge this, we need @jfeng-salesforce to sign the Salesforce.com Contributor License Agreement. |
org:create fails with --wait 2 as it claims the minimum is 3 min.
totsukahyt
pushed a commit
to totsukahyt/sfdx-circleci
that referenced
this pull request
Sep 17, 2020
totsukahyt
pushed a commit
to totsukahyt/sfdx-circleci
that referenced
this pull request
Sep 17, 2020
totsukahyt
pushed a commit
to totsukahyt/sfdx-circleci
that referenced
this pull request
Sep 17, 2020
…com#7 [update] refs forcedotcom#7 翻訳漏れ修正
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two fixes here:
According to to the Readme.MD file, the SFDX user should be stored in $HUB_SFDX_USER, but the config.yaml file is checking the $HUB_SFDC_USER (SFDC instead of SFDX). This updates the username argument used in the circleci config.yml file to check the parameter defined in the Readme.MD / CircleCI environment variable.
force:org:create --wait 2 throws an exception claiming the minimum wait time is 3min. Updating the parameter to reflect the new minimum wait time.