feat: add risk_cattle column and Ind_12_pasture_2020 placeholder indicator#224
Closed
andyarnell wants to merge 1 commit into
Closed
feat: add risk_cattle column and Ind_12_pasture_2020 placeholder indicator#224andyarnell wants to merge 1 commit into
andyarnell wants to merge 1 commit into
Conversation
…_livestock; fix run_pytest.sh venv activation; update copilot-instructions Cattle pathway follows the same decision tree as acrop for now (Ind_01, Ind_02, Ind_04). Ind_12_pasture_2020 exists as a placeholder indicator column with nothing feeding it yet (use_for_risk_cattle=0) -- will be wired into the decision tree once pasture data coverage and silvopastoral nuances are reviewed. Pasture datasets still have use_for_risk=1 (feeding Ind_02 for pcrop/acrop); whether this is correct needs checking with Brazil dataset authors.
Collaborator
Author
|
Closing as out of date. Will revisit the cattle risk / Ind_12_pasture_2020 work separately if we come back to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds risk_cattle as a new output column, following the same decision tree as acrop for now. Ind_12_pasture_2020 exists as a placeholder indicator with nothing feeding it yet -- it will be wired into a revised cattle decision tree once pasture data coverage and silvopastoral nuances are reviewed (see #188).
Breaking change: risk_livestock renamed to risk_cattle in filter_to_risk_columns() output
Ind_12_pasture_2020 added as indicator column (always "no" until use_for_risk_cattle datasets are added)
run_pytest.sh fixed to activate .venv before running pytest
copilot-instructions.md updated to reflect cattle instead of livestock
Note for review: the 3 Brazil pasture datasets (nBR_INPE_TCamz_pasture_2020, nBR_INPE_TCcer_pasture_2020, nBR_MapBiomas_col9_pasture_2020) currently have use_for_risk=1, meaning they feed Ind_02 for pcrop and acrop. This is likely wrong -- pasture is cattle evidence, not a perennial/annual crop commodity indicator. Flagging here for confirmation before changing, as these were set deliberately in the original Brazil dataset PR.