Skip to content

Validate executor timeouts and normalize lock settings#22

Merged
foreverest merged 2 commits intomainfrom
codex/timeout-validation
Feb 10, 2026
Merged

Validate executor timeouts and normalize lock settings#22
foreverest merged 2 commits intomainfrom
codex/timeout-validation

Conversation

@foreverest
Copy link
Copy Markdown
Owner

Summary

  • normalize the timeout passed to IdempotentExecutor.run, enforce positive finite milliseconds, and compute lock retry parameters with explicit integers
  • extract shared constants for timeout defaults, retry delay, and extension buffer, and add comprehensive tests covering invalid values and the normalized settings

Testing

  • Not run (not requested)

@foreverest foreverest merged commit a668286 into main Feb 10, 2026
3 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (373b24a) to head (b236c71).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          200       213   +13     
  Branches        42        45    +3     
=========================================
+ Hits           200       213   +13     
Flag Coverage Δ
node20.x 100.00% <100.00%> (ø)
node22.x 100.00% <100.00%> (ø)
node24.x 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant