fix lua table index for build_string vector#10
Open
rgnine wants to merge 1 commit intoforhappy:masterfrom
Open
fix lua table index for build_string vector#10rgnine wants to merge 1 commit intoforhappy:masterfrom
rgnine wants to merge 1 commit intoforhappy:masterfrom
Conversation
Another issue where lua tables start at index 0 instead of 1. This caused checks for example for number of children in
ret, children = zklua.get_children(zh, path, 0)
to return 0 to a subsequent size check with #children as the table is { 0 -> firstchild }
With this change, the first children entry will be pushed to lua index 1 and #children will work as expected as will all standard lua iterator functions that expect arrays to start at 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another issue where lua tables start at index 0 instead of 1. This caused checks for example for number of children in
ret, children = zklua.get_children(zh, path, 0)
to return 0 to a subsequent size check with #children as the table is { 0 -> firstchild }
With this change, the first children entry will be pushed to lua index 1 and #children will work as expected as will all standard lua iterator functions that expect arrays to start at 1.